Skip to content

Reformat the entire codebase using cargo fmt#1585

Merged
nrc merged 1 commit intorust-lang:masterfrom
kinnison:kinnison/cargo-fmt
Dec 26, 2018
Merged

Reformat the entire codebase using cargo fmt#1585
nrc merged 1 commit intorust-lang:masterfrom
kinnison:kinnison/cargo-fmt

Conversation

@kinnison
Copy link
Copy Markdown
Contributor

To make sure that people using editors which use rustfmt by default
on saving don't touch more lines than intended when working on the
rustup codebase, we'll take the hit to format it all once.

Please note, this depends on #1583 (as it effectively contains that commit also)

@nrc
Copy link
Copy Markdown
Member

nrc commented Dec 18, 2018

Did you do any manual fixups or is this all just running cargo fmt?

@kinnison
Copy link
Copy Markdown
Contributor Author

kinnison commented Dec 19, 2018

@nrc The formatting commit was pure cargo fmt and no manual changes.

To make sure that people using editors which use rustfmt by default
on saving don't touch more lines than intended when working on the
rustup codebase, we'll take the hit to format it all once.
@kinnison
Copy link
Copy Markdown
Contributor Author

All I did was rebase against current master and confirm there were no further formatting changes needed.

Copy link
Copy Markdown
Member

@nrc nrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nrc nrc merged commit 61f57bb into rust-lang:master Dec 26, 2018
@kinnison kinnison deleted the kinnison/cargo-fmt branch January 9, 2019 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants